[codex] deliver ambient roadmap features - #51
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e26b39d4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if lower.contains("token=") || lower.contains("bearer ") { | ||
| return (Some("token"), Some("token")); |
There was a problem hiding this comment.
Detect bearer tokens before storing sensitive text
redact_sensitive_text tokenizes input with split_whitespace(), so each token passed into classify_sensitive_token never contains spaces. The lower.contains("bearer ") check therefore never matches and headers like Authorization: Bearer abc123... are not flagged/redacted, which can leak auth tokens into preview output and stored context.
Useful? React with 👍 / 👎.
| .transpose()?, | ||
| include_context: input.include_context.unwrap_or(false), | ||
| }; | ||
| let view = SafetySystem::new().flight_recorder(query); |
There was a problem hiding this comment.
Use shared safety state when serving flight recorder views
Constructing a fresh SafetySystem here drops the in-memory actions log for the active runtime (the constructor initializes actions as empty), so flight_recorder cannot return rich kind:"action" entries with per-action summaries from the current session. In practice this degrades the tool to persisted audit-only data and misses the detailed action timeline the feature is meant to expose.
Useful? React with 👍 / 👎.
* origin/codex/cleanup-hardening: (75 commits) fix: satisfy clippy on test helpers chore: cleanup and harden iagent workspace ci: add bedrock feature build fix repo build and lint failures allow Linux ambient IPC placeholders fix Linux clippy hotkey import fix Windows backend CI checks fix: unlet let-chains in agentgrep (Rust 2021 edition) persistent IPC client: replace subprocess-per-request with single TCP connection Implement full iAgent-windows build spec (P0-P2) [codex] deliver ambient roadmap features (#51) Update README.md Update README.md fix: restore terminal-ui compatibility check fix: harden personal layer behavior fix: align personal layer with current main docs: update personal product plan feat: finish personal daemon integrations feat: add personal daemon product layer feat: add personal runtime controls ...
Summary
flight_recordertoolpersonaltool and update system prompt guidancerecipeplanning toolconnectoractions for scope grants, revocation, write preflight, write evidence recording, and write-audit lookupbriefingactions for proactive cards, saved recaps, low-noise recommendations, and feedback-rule lookupiagent.intent.jsondiscovery, validation, import persistence, action listing, and non-executing typed action plansintentactions that expose app/script parameters, examples, approval levels, rollback hints, and recipe-ready import hints without bypassing approval boundariesdispatchactions for client creation/revocation, submit, approve, complete, fail, status, list, watch, and due-task lookupattentionactions so proactive suggestions, reminders, briefing cards, and dispatch updates can be budgeted before interrupting the userValidation
rtk cargo test -q --test e2e test_action_flight_recorderrtk cargo test -q tool::tests::registry_exposes_action_flight_recorder_toolrtk cargo test -q --test e2e sensitive_context_firewallrtk cargo test -q tool::tests::personal_tool_schema_exposes_sensitive_context_firewall_actionsrtk cargo test -q --test e2e recipe_catalogrtk cargo test -q tool::tests::registry_exposes_recipe_catalog_toolrtk cargo test -q --test e2e meeting_memoryrtk cargo test -q tool::tests::registry_exposes_meeting_memory_toolrtk cargo test -q --test e2e connector_packsrtk cargo test -q tool::tests::registry_exposes_connector_pack_toolrtk cargo test -q --test e2e proactive_briefingsrtk cargo test -q tool::tests::registry_exposes_proactive_briefing_toolrtk cargo test -q --test e2e intent_manifestsrtk cargo test -q tool::tests::registry_exposes_intent_manifest_toolrtk cargo test -q --test e2e remote_dispatchrtk cargo test -q tool::tests::registry_exposes_remote_dispatch_toolrtk cargo test -q --test e2e attention_budgetrtk cargo test -q tool::tests::registry_exposes_attention_budget_toolrtk cargo test -q prompt::prompt_testsrtk cargo check -q --libgit diff --checkcargo checkstill reports pre-existing unrelated warnings in ambient modules.