Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional characters to tag filter regex #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robertozmc
Copy link

Fixing an issue when tagFilter value in setJestCucumberConfiguration was set with dot characters, e.g.

setJestCucumberConfiguration({ tagFilter: '@10.2.2_1' });

causing following error

Error: Could not parse tag filter "@10.2.2_1"
 ❯ convertTagFilterExpressionToFunction node_modules/jest-cucumber/src/tag-filtering.ts:40:11
 ❯ checkIfScenarioMatchesTagFilter node_modules/jest-cucumber/src/tag-filtering.ts:59:25
 ❯ setScenarioSkipped node_modules/jest-cucumber/src/tag-filtering.ts:67:32
 ❯ node_modules/jest-cucumber/src/tag-filtering.ts:84:61
 ❯ applyTagFilters node_modules/jest-cucumber/src/tag-filtering.ts:84:45
 ❯ defineFeature node_modules/jest-cucumber/src/feature-definition-creation.ts:383:63
 ❯ node_modules/jest-cucumber/src/automatic-step-binding.ts:44:7
 ❯ Proxy.<anonymous> node_modules/jest-cucumber/src/automatic-step-binding.ts:43:14

Example of tag with dots from official cucumber documentation:
https://cucumber.io/docs/cucumber/api/?lang=javascript#link-to-other-documents

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant