Support for docstrings in scenario outlines #80
Conversation
| scenarioStep.stepArgument instanceof String | ||
| ) { | ||
| Object.keys(exampleTableRow).forEach((nextTableColumn) => { | ||
| stepArgument = (stepArgument as string).replace( |
There was a problem hiding this comment.
It's possible that a doc string might have a field specified more than once, but this code will only replace one instance. It would be better to use a regex with /g to ensure each column gets replaced globally.
There was a problem hiding this comment.
Ah, nice catch that would indeed be quite possible. I'll update the tests to reflect this as well.
I believe this is a problem also with the current implementation of scenario outlines and placeholders in steps and arguments (titles use regex an works fine). Do you want me to change those into regex checks as well? (I'll just have to come up with some good test scenario where you'd write something like Given I <placeholder> <placeholder> 🤔
There was a problem hiding this comment.
The fix now uses regex.
| @@ -0,0 +1,21 @@ | |||
| Feature: Certificate manufaturing | |||
There was a problem hiding this comment.
Looks like a typo: manufacturing is missing the "c".
There was a problem hiding this comment.
Indeed :)
|
@SirSkorpan - thanks for contributing this fix! I commented on a couple of small tweaks, but it looks good otherwise. Once those issues are resolved, I can merge and publish. I will be publishing this in a beta package for now instead of in the mainline because I've been a bad maintainer the last several months, and master still has some beta functionality in it from a while back (#27). |
It was pointed out in review that the code would fail if a placeholder was repeated. The tests and example code now reflects this scenario. Also fixed minor typo in feature titles.
…ables and regular outline steps
|
@bencompton I added a few tests for using repeating 's in steps, docstrings and gherkin tables. Hopefully you feel that those belong in this PR as well. As I was adding regex in the replace method for my new code I figured I might as well use it in the old code as well to add support not just to docstrings. Also added some information to the |
Also minor fixed in formatting of README.md
|
@SirSkorpan - Thanks for fixing the replacement in both places, and also adding additional examples! Your changes are now merged and published to v2.0.13 (tagged as "next"). |
Figured I might as well just create the pull request, I can always squash the commits later.
I've added what I hope is a solution to using Docstrings with Scenario Outlines as described in #7 and #79. The implementation is concentrated to
src/parsed-feature-loading.tsI also added a couple of examples for TypeScript and ECMAScript to illustrate the new functionality (it was previously not possible to use Docstrings and Scenario Outlines together).Have a look and ping me if there are any concerns.