Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close open resources #3250

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+37 −19
Open

Close open resources #3250

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49618be
Close a temporary file acting as a fake socket
kurtmckee Jul 25, 2024
62530ef
Close open sockets when an exception is encountered
kurtmckee Jul 25, 2024
dc197ff
Close open files to prevent `ResourceWarning` in the test suite
kurtmckee Jul 25, 2024
7756175
Escalate warnings to errors during testing
kurtmckee Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Close open files to prevent ResourceWarning in the test suite
@kurtmckee
kurtmckee committed Jul 25, 2024
commit dc197ffbf91c8dc1de28388e02e01f371d849d66
32 changes: 19 additions & 13 deletions tests/test_reload.py
View file
Original file line number Diff line number Diff line change
@@ -39,9 +39,12 @@ def test_reload_on_syntax_error():
log = mock.Mock()
worker = MyWorker(age=0, ppid=0, sockets=[], app=app, timeout=0, cfg=cfg, log=log)

worker.init_process()
reloader.start.assert_called_with()
reloader.add_extra_file.assert_called_with('syntax_error_filename')
try:
worker.init_process()
reloader.start.assert_called_with()
reloader.add_extra_file.assert_called_with('syntax_error_filename')
finally:
worker.tmp.close()


def test_start_reloader_after_load_wsgi():
@@ -56,13 +59,16 @@ def test_start_reloader_after_load_wsgi():
log = mock.Mock()
worker = MyWorker(age=0, ppid=0, sockets=[], app=app, timeout=0, cfg=cfg, log=log)

worker.load_wsgi = mock.Mock()
mock_parent = mock.Mock()
mock_parent.attach_mock(worker.load_wsgi, 'load_wsgi')
mock_parent.attach_mock(reloader.start, 'reloader_start')

worker.init_process()
mock_parent.assert_has_calls([
mock.call.load_wsgi(),
mock.call.reloader_start(),
])
try:
worker.load_wsgi = mock.Mock()
mock_parent = mock.Mock()
mock_parent.attach_mock(worker.load_wsgi, 'load_wsgi')
mock_parent.attach_mock(reloader.start, 'reloader_start')

worker.init_process()
mock_parent.assert_has_calls([
mock.call.load_wsgi(),
mock.call.reloader_start(),
])
finally:
worker.tmp.close()