Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external testdata module #12

Merged
merged 6 commits into from
May 3, 2022

Conversation

eliasnaur
Copy link
Contributor

@eliasnaur eliasnaur commented Apr 29, 2022

This PR removes the large test data files and loads them from the external module textlayout-testdata.

This fixes #10 insofar the Go module download of the main repository textlayout will be small. A git history rewrite will slim the repository itself.

@eliasnaur
Copy link
Contributor Author

I can successfully run go test ./... by adding a replace to go.mod:

$ go mod edit -replace github.com/benoitkugler/textlayout-testdata=github.com/eliasnaur/textlayout-testdata@966122874d9ef84315ccbbc378010a3d60c3b134

@benoitkugler benoitkugler changed the base branch from main to move-testdata May 3, 2022 18:15
@benoitkugler benoitkugler merged commit 3d482b0 into benoitkugler:move-testdata May 3, 2022
@eliasnaur eliasnaur deleted the move-testdata branch May 4, 2022 12:59
@benoitkugler
Copy link
Owner

Thanks a lot @eliasnaur for this PR, now merged back to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repository is large (200MB)
2 participants