feat: beacon client-authorized requests to private data endpoints #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsfk
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Seems to work fine, one comment about config changes.
I was right to suspect that I wrote katsu_network_call() first, and added the GET stuff later. I'll at least change the name to katsu_post() at some point, not sure yet if it needs more refactor than that.
I'm assuming katsu_network_call() didn't get all the extra conditional requires_auth handling that katsu_get() got, because katsu_network_call() only does query stuff that always needs full auth.
gsfk
reviewed
Sep 13, 2024
gsfk
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.