Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle multiple response messages #67

Merged
merged 1 commit into from
Jan 9, 2024
Merged

handle multiple response messages #67

merged 1 commit into from
Jan 9, 2024

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Jan 9, 2024

Handle multiple messages in the response info field. (Redmine #2040). Currently only one message is possible, but more are coming, (eg Redmine #1918).

  • this stamps all messages as "info" level
  • we could add more levels in the future (eg "warning", although this may be handled by the spec in the future)
  • errors have their own response format so don't need to appear here

davidlougheed
davidlougheed approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk gsfk merged commit 6385ada into master Jan 9, 2024
1 check passed
@gsfk gsfk deleted the features/info-field branch January 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfk @davidlougheed