Merge pull request #16 from bento-platform/fix/bar-grid-ticks

fix(charts): correct # of bar chart dividing lines
bento-platform · Feb 12, 2024 · 44c2ef8 · 44c2ef8
2 parents 369b347 + a91b4f1
commit 44c2ef8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Components/Charts/BentoBarChart.tsx b/src/Components/Charts/BentoBarChart.tsx
@@ -64,7 +64,7 @@ const BentoBarChart = ({ height, width, units, title, onClick, colorTheme = 'def
 
   const cartesianGridVerticalCoordinatesGenerator: CartesianGridProps['verticalCoordinatesGenerator'] = ({ xAxis }) => {
     const points = [xAxis?.x ?? 0];
-    for (let i = 0; i <= xAxis?.tickCount; i++) {
+    for (let i = 0; i <= data.length; i++) {
       points.push(points[i] + xAxis.bandSize);
     }
     return points;

diff --git a/test/js/TestBarChart.tsx b/test/js/TestBarChart.tsx
@@ -16,6 +16,11 @@ const TestBarChart: React.FC = () => {
             { x: 'SB', y: 60 },
             { x: 'AU', y: 30 },
             { x: 'XA', y: 80 },
+            { x: 'BB', y: 50 },
+            { x: 'BC', y: 75 },
+            { x: 'BD', y: 60 },
+            { x: 'BE', y: 30 },
+            { x: 'BF', y: 80 },
           ]}
           units="management units"
           height={sizeStateFixed.height}