Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(charts): Added a chartclick event to the BaseBarChart #29

Merged
merged 2 commits into from
Aug 29, 2024
Merged

feat(charts): Added a chartclick event to the BaseBarChart #29

merged 2 commits into from
Aug 29, 2024

Conversation

SanjeevLakhwani
Copy link
Collaborator

  • Adding this allows to handle clicks on a chart if they are not on top of a Bar

davidlougheed
davidlougheed approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. no pointer cursor over non-bar portions of chart might be confusing in UI context.

@SanjeevLakhwani SanjeevLakhwani merged commit 14fbfc0 into main Aug 29, 2024
1 check passed
@SanjeevLakhwani SanjeevLakhwani deleted the ChartClickHandler branch August 29, 2024 18:58
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
@semantic-release-bot
chore(release): 2.9.0 [skip ci]
5634d85 
# [2.9.0](v2.8.0...v2.9.0) (2024-08-29)

### Features

* **charts:** Added a chartclick event to BaseBarChart ([88bf4ae](88bf4ae))
* **charts:** Added a chartclick event to the BaseBarChart ([#29](#29)) ([14fbfc0](14fbfc0))
@SanjeevLakhwani SanjeevLakhwani self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees

@SanjeevLakhwani SanjeevLakhwani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanjeevLakhwani @davidlougheed