Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added optional id to data #34

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat(chart): Added optional id to data #34

merged 1 commit into from
Nov 6, 2024

Conversation

SanjeevLakhwani
Copy link
Collaborator

This id is copied over to onClick responses by recharts which helps recognize keys that are different from title such as translation.

Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SanjeevLakhwani SanjeevLakhwani merged commit a2daee4 into main Nov 6, 2024
1 check passed
@SanjeevLakhwani SanjeevLakhwani deleted the data-id branch November 6, 2024 18:30
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
# [2.10.0](v2.9.3...v2.10.0) (2024-11-06)

### Features

* **chart:** Added optional id to data ([798e02e](798e02e))
* **chart:** Added optional id to data ([#34](#34)) ([a2daee4](a2daee4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants