feat!: add map chart components #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
force-pushed
the
feat/maps
branch
from
7156565
to
edd02da
Compare
davidlougheed
changed the title
v-rocheleau
reviewed
Sep 21, 2023
gsfk
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
No real comments on React code from my end, and no issues in testing.
For the readme:
- "Using a Map" doesn't mention
PointMap - do the maps use
ChartConfigProvideror is this only for Pie and Bar charts?
I'm assuming some features (like remembering which map position you were centered on last) will be handled by whatever app is calling the charts library, rather than the library itself.
The only really obvious missing element is translation handling, map labels appear to be in "local" language only. For the North this actually looks good, since local languages are included rather than forgotten, but in the future there may be a need for specifying, eg, English or French.
davidlougheed
requested review from
v-rocheleau
and removed request for
SanjeevLakhwani
v-rocheleau
approved these changes
Sep 27, 2023
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.