feat: skill trigger discoverability + baseline convergence#87
Merged
Conversation
- add `prospec agent triggers`: emit a fill-missing skill_triggers localization scaffold (English baselines from SKILL_DEFINITIONS) - add `prospec config example`: print a complete, annotated .prospec.yaml reference covering every schema field (INIT_COMMANDS, runs pre-init) - extract computeUnlocalizedSkills as the single-source fill-missing set, shared by the agent-sync hint and `agent triggers` - point the agent-sync hint and quickstart/upgrade onboarding skills at `prospec agent triggers` - remove dead config schema fields (project.version, knowledge.files + KNOWLEDGE_FILE_TYPES, paths catchall); migrate .passthrough() to .loose() - add contract tests (scaffold YAML round-trip, config-example completeness, onboarding refs) + US-3 backward-compat - sync READMEs, factual counts, and affected-module knowledge
- graduate agent-integration: US-439 + REQ-AGNT-036/SERVICES-066/TESTS-052 (ADDED); REQ-AGNT-021/TEMPLATES-108/121 (MODIFIED, point to `prospec agent triggers`) - graduate project-setup: US-018/019 + REQ-CLI-021/TYPES-062/TESTS-051 (ADDED) - copy archive summary to specs/_archived-history/2026-07-12-emit-trigger-scaffold.md - bump product.md; refresh raw-scan.md - harvest lessons ledger (module-readme manual counts +1; generated-file module-stale gotcha)
- converge 8 skills' triggers to prospec-specific, collision-free, >= 3-word sets (new-story/plan/review/verify/archive/learn/quickstart/upgrade); drop bare over-broad words (upgrade, I want to, setup, done, critical, feedback, clean up, migrate version, version bump) - fix prospec-plan's sub-3 gap with `technical plan` (not `implementation plan`, which would collide with `implement`) - machine-enforce REQ-AGNT-033's >= 3-triggers intent via a skill-format contract assertion with a shared-predicate mutation guard - mirror the convergence into .prospec.yaml Chinese skill_triggers (still collision-free) - re-sync deployed SKILL.md frontmatter + AGENTS.md via agent sync - correct a stale templates reference count (20 -> 19) in module-map/index.md carried over from emit-trigger-scaffold
- graduate agent-integration: REQ-TESTS-053 (ADDED, >= 3-triggers contract); REQ-AGNT-033 (MODIFIED, baselines converged to prospec-specific + >= 3 machine-enforced) - copy archive summary to specs/_archived-history/2026-07-12-converge-skill-triggers.md - refresh raw-scan.md - harvest lessons ledger (generated-file module-stale +1; test/structural-false-green +1 -- the >= 3 mutation guard was near-tautological)
Prospec Check |
Test Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two stacked, skill-trigger–related changes, merged as one PR since both concern skill triggers.
1. emit-trigger-scaffold — make
.prospec.yamldiscoverable to onboarding agentsprospec agent triggers: emit a fill-missingskill_triggerslocalization scaffold (English baselines sourced fromSKILL_DEFINITIONS) so onboarding agents translate values in place instead of grepping a deployed SKILL.md or reading the minified binaryprospec config example: print a complete, annotated.prospec.yamlreference covering every schema field (runs pre-init, inINIT_COMMANDS)computeUnlocalizedSkillsas the single-source fill-missing set, shared by the agent-sync hint andagent triggersprospec agent triggersproject.version,knowledge.files+KNOWLEDGE_FILE_TYPES,pathscatchall); migrate deprecated.passthrough()→ Zod 4.loose()2. converge-skill-triggers — tighten over-broad trigger baselines
upgrade,I want to,setup,done,critical,feedback,clean up,migrate version,version bump)prospec-plan's sub-3 gap withtechnical plan(notimplementation plan, which would collide withimplement).prospec.yamlChineseskill_triggersTesting
typecheck+lintclean.prospec.yamlChinese triggers) → 0 violations; all 17 skills ≥3 triggersProspecConfigSchema; every schema field present)Notes
agent-integration/project-setupfeature specs.