Skip to content

fix(rust): update handling of Cow<_, u8> to be compatible with rust 1.93 as_ref changes #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillLillis merged 1 commit into from
Feb 7, 2026
Merged

fix(rust): update handling of Cow<_, u8> to be compatible with rust 1.93 as_ref changes #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions asm-lsp/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,8 +1127,7 @@ pub fn populate_instructions(xml_contents: &str) -> Result<Vec<Instruction>> {
}
},
"nacl-version" => {
curr_instruction_form.nacl_version =
value.as_ref().first().copied();
curr_instruction_form.nacl_version = value.first().copied();
}
"nacl-zero-extends-outputs" => match ustr::get_str(&value) {
"true" => {
Expand Down Expand Up @@ -1217,12 +1216,12 @@ pub fn populate_instructions(xml_contents: &str) -> Result<Vec<Instruction>> {
}
}
}
b"input" => match value.as_ref() {
b"input" => match value.iter().as_slice() {
b"true" => input = Some(true),
b"false" => input = Some(false),
_ => return Err(anyhow!("Unknown value for operand type")),
},
b"output" => match value.as_ref() {
b"output" => match value.iter().as_slice() {
b"true" => output = Some(true),
b"false" => output = Some(false),
_ => return Err(anyhow!("Unknown value for operand type")),
Expand Down
Loading