Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore changes and tried data100 and data8 for classes #83

Merged
merged 17 commits into from
Aug 16, 2024

Conversation

jlucarga
Copy link
Collaborator

Run the following command line to test if you still getting an error for data8 and data100:

python refactor_testing_query_courseid.py 2242 data8 data100 compsci189

I will keep editing to print the same lines as the original query_courseid.py and add Shane's edit recommendations

Copy link
Contributor

@shaneknapp shaneknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on the first pass, we can go over the tooling in more detail tomorrow

scripts/test/main.py Outdated Show resolved Hide resolved
scripts/test/main.py Outdated Show resolved Hide resolved
scripts/test/main.py Outdated Show resolved Hide resolved
scripts/test/main.py Outdated Show resolved Hide resolved
scripts/test/main.py Outdated Show resolved Hide resolved
scripts/test/api.py Outdated Show resolved Hide resolved
scripts/test/helpers.py Outdated Show resolved Hide resolved
scripts/test/validation.py Outdated Show resolved Hide resolved
@@ -2395,7 +2395,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.6"
"version": "3.11.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this to the prior version pls ty

@shaneknapp
Copy link
Contributor

@jlucarga a couple of quick things and i believe we can merge:

  1. run git mv scripts/test/* scripts/ to move your files in the test subdir up one level
  2. then git mv main.py query_courseid.py to rename main script

after that we can merge!

@shaneknapp shaneknapp merged commit 0931773 into berkeley-dsep-infra:main Aug 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants