Terminal Theme Updated to RT6#1
Open
tbrumm wants to merge 9 commits into
Open
Conversation
First version to bring this extension to RT6
mentioned rt6 as new default
Ignore some more files
- main.css: fix @import paths (remove leading comment blocking CSS::Squish, correct relative path to ../elevator/main.css) - terminal.css: exclude button/input/select from monospace font to prevent navbar overflow on "Create new ticket" and search controls - terminal.css: fix terminal SVG logo aspect-ratio (viewBox 858×144 vs wrong width/height attrs) - terminal.css: add light-mode btn-secondary, topactions button styles, form-control focus state, and status badge overrides Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Headings (h2/h3) inside .titlebox-title were getting color: #0a2200 from the global h1-h4 rule, making them invisible on the #2d7a2d background. Override to #f2f7ed inside the title bar. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Titlebox titles that are saved-search links use <a> inside .left, which gets --bs-link-color (#145214, dark green) overriding the .left color rule. Explicitly target .left a and .left a:visited with #f2f7ed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
elevator/boxes.css sets .titlebox .card-header to font-size:larger, then .left adds another 1.1em on top. With a monospace font this produces oversized headers, especially visible on narrow chart widgets. Reset card-header to 1rem so the .left 1.1em resolves to a normal 1.1rem. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Hi @tbrumm , the team is all very busy right now working on the next RT release. Once that is out, hopefully we'll have some time in a few weeks to work on some other things. |
|
Hello @tbrumm , I took a look at the PR and there are some good changes but also some issues that are addressed in the rt6-update-2 branch (https://github.com/bestpractical/rt-extension-terminaltheme/tree/rt6-update-2). Here are some of the issues:
If you could combine the best of your PR with the best of that branch it should get the theme most of the way there. We would also like to make sure that you review all changes/commits made by AI tools such as Claude to ensure the changes look correct. Thanks, Brad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey BPS,
please check my changes to Terminal Theme for RT6