Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hover point throttle curve adjustment #4245

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marc-frank
Copy link

  • added input for value adjustment
  • added text to locales
  • adjusted throttle curve math to take hover point into account

Hi, I'd like to propose a new feature / change to an existing feature: setting the hover point of a quad to 50% of the throttle stick range.

I have been using subtrim in EdgeTX in center only mode to achieve this already, but it is a quad specific setting which I'd like to have in Betaflight.

Setting the hover point to 50% stick travel gives you a lot more "resolution" between 0 throttle and the hover point, therefore making flying at lower throttle in tight spaces a lot easier.

https://discord.com/channels/868013470023548938/1303071076342956072

hover_point.mp4

- added input for value adjustment
- added text to locales
- adjusted throttle curve math to take hover point into account
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit a36e556
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6738a00b44677b000857e25b
😎 Deploy Preview https://deploy-preview-4245.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis
Copy link
Member

There is no need to add translations beside EN language messages. Other languages will be translated using crowdin.

@marc-frank
Copy link
Author

Oh okay, sorry. Should I remove the other ones?

@@ -113,6 +113,7 @@ pid_tuning.initialize = function (callback) {

$('.throttle input[name="mid"]').val(FC.RC_TUNING.throttle_MID.toFixed(2));
$('.throttle input[name="expo"]').val(FC.RC_TUNING.throttle_EXPO.toFixed(2));
$('.throttle input[name="hover"]').val(FC.throttle_HOVER.toFixed(2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FC.THROTTLE_HOVER should be a member of some PG to be decided in firmware.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use FC.RC_TUNING.throttle_HOVER it should be added to firmware MSP message.

- adjusted control point positions to avoid a step in the throttle curve
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@github-actions github-actions bot added Inactive and removed Inactive labels Jan 9, 2025
@nerdCopter
Copy link
Member

nerdCopter commented Jan 15, 2025

@marc-frank , if it is not clear, please understand if you wish to achieve this feature, the firmware must be modified as well as previously stated by @haslinghuis .

@bw1129, @ChrisRosser , any thoughts on this feature?

@marc-frank
Copy link
Author

I have a draft for the modification of the FC firmware. Not completed yet and I haven't figured out how I can test it myself. I'll keep working on it.

@ChrisRosser
Copy link
Contributor

@bw1129, @ChrisRosser , any thoughts on this feature?

I think it's a natural extension of the control we have over throttle feel right now.

Throttle MID and EXPO allow fine resolution around the hover point but don't allow you to control where the hover point is in terms of stick travel. This feature accomplishes that. I don't like the way it creates a discontinuity in the throttle curve.

I think modifying the underlying throttle curve as a bezier with HOVER POINT would give the same effect without a discontinuity of gradient. MID and EXPO could then work on that bezier curve to add expo.

Copy link

@OGCJM11 OGCJM11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

req change

@bw1129
Copy link

bw1129 commented Jan 15, 2025

@marc-frank @nerdCopter @haslinghuis @ChrisRosser

I really like this! As Chris said, a natural extension/improvement to what's there.

@ChrisRosser
Copy link
Contributor

Here is a simple example of how to make Hoverpoint smooth.
Throttle curve.xlsx

@marc-frank
Copy link
Author

Here is a simple example of how to make Hoverpoint smooth. Throttle curve.xlsx

that looks nice. another good way to do it
but have you tried emulating the the throttle curve with dicontinuity in the radio? it's really not that bad.

  1. everything default
  2. fly and find hover point percentage
  3. land, bring throttle stick to 50%
  4. edit subtrim in center only mode until osd th% shows the hover %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants