Add GNNS VIRTUAL device option #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
haslinghuis
commented
Jan 9, 2025
haslinghuis
commented
- keep in sync with The imitation of GPS is added for SITL betaflight#14131
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
blckmn
approved these changes
Jan 10, 2025
haslinghuis
commented
Jan 14, 2025
src/js/tabs/gps.js
Outdated
| @@ -162,7 +167,7 @@ gps.initialize = async function (callback) { | |||
| gpsAutoBaudGroup.toggle( | |||
| (ubloxSelected || mspSelected) && semver.lt(FC.CONFIG.apiVersion, API_VERSION_1_46), | |||
| ); | |||
| gpsAutoConfigGroup.toggle(ubloxSelected || mspSelected); | |||
| gpsAutoConfigGroup.toggle(ubloxSelected || mspSelected || virtualSelected); | |||
There was a problem hiding this comment.
do not think we need auto config with virtual. check later.
There was a problem hiding this comment.
@demvlad suggestion ?
There was a problem hiding this comment.
Yes ofcourse, the virtual gps is "configed" from start and does not need any autoconfig.
haslinghuis
force-pushed
the
gps-virtual
branch
from
339fb24 to
3b99a62
Compare
|
nerdCopter
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.