Add binary sub protocol to allow communication with websockify. #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
haslinghuis
reviewed
Jan 15, 2025
…ing binary one used by websockify
|
haslinghuis
approved these changes
Jan 15, 2025
haslinghuis
changed the title
blckmn
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the protocol definition when opening an WebSocket for connecting to the FC boards in the configurator.Currently we require using Websockify to proxy requests from localhost to the FC on the network, Websockify does not support (at least on the latest branch) this protocol, nor is it specified by IANA.This has been tested on two boards and works for connecting to it - it does not however work for flashing (specifically detecting at the very least).
EDIT:
Added
binaryas a subprotocol as well since that is at least one of the ones accepted by websockify.Reference: