Feature/madflight fc3 config new sensors#1030
Feature/madflight fc3 config new sensors#1030gintaris wants to merge 4 commits intobetaflight:masterfrom
Conversation
Update MADFLIGHT FC3 configuration for internal I2C sensors: Changes: - Add INA226 power monitor configuration (I2C0, 0x40, 2mΩ shunt) - Use INA226 for both current and voltage measurement - Configure I2C0 at 100kHz with internal pull-ups - Add BMP580 barometer on I2C0 - Add MSP Displayport OSD configuration - Set DSHOT600 as default motor protocol (ONESHOT125 as fallback) - Remove ADC-based battery voltage sensing Sensors on I2C0 bus: - BMP580 barometer (0x47) - MMC5603 magnetometer (0x30) - INA226 power monitor (0x40) Tested on: MADFLIGHT FC3 (RP2350B)
Matches betaflight/betaflight PR #14925 BMP5xx driver rename.
Remove Oneshot125 override - use platform default DSHOT600. Oneshot125 commented out for reference if analog ESCs needed.
|
Caution Review failedFailed to post review comments WalkthroughSwitches board sensors to internal I2C0: enables I2C0 clock/pull-up, replaces ADC VBAT metering with INA226-based current/voltage sensing, moves barometer and magnetometer to BMP580/BMP581 and MMC5603 on I2C0, and adds related sensor/macros in Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
haslinghuis
left a comment
There was a problem hiding this comment.
Awaiting updates to use CURRENT_METER_INA226 and VOLTAGE_METER_INA226
- there is no USE_VOLTAGE_METER_INA226 define.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Add internal sensor configuration for MADFLIGHT FC3: INA226 Power Monitor (PR #14927): - USE_CURRENT_METER_INA226 enabled - DEFAULT_CURRENT_METER_SOURCE = CURRENT_METER_INA226 - DEFAULT_VOLTAGE_METER_SOURCE = VOLTAGE_METER_INA226 - Config: 0x40 address, 2mΩ shunt, 50A max BMP580 Barometer (PR #14925): - USE_BARO_BMP580/BMP581 on I2C0 - DEFAULT_BARO_BMP580 MMC5603 Magnetometer (PR #14924): - USE_MAG_MMC5603 on I2C0 I2C0 config: - 100kHz clock speed - Internal pull-ups enabled Addresses reviewer comment requesting CURRENT_METER_INA226 and VOLTAGE_METER_INA226 usage.
There are several PR's dependencies with this one : |
PR: MADFLIGHT_FC3 - Add internal I2C sensor configuration
Repository: betaflight/config
Branch: feature/madflight-fc3-sensors
Target: master
Title
MADFLIGHT_FC3: Add internal I2C sensor configurationDescription
Summary
Update MADFLIGHT_FC3 board configuration to enable internal I2C sensors.
Changes
Related PRs (betaflight/betaflight)
Hardware
Testing
make MADFLIGHT_FC3PR Link
Create PR: https://github.com/gintaris/betaflight_config/pull/new/feature/madflight-fc3-sensors
Set:
betaflight/configmastergintaris/betaflight_configfeature/madflight-fc3-sensorsSummary by CodeRabbit
New Features
Bug Fixes