Skip to content

Add SYSTEM_HSE_MHZ define to DAKEFPVF405 target#1032

Merged
haslinghuis merged 1 commit intobetaflight:masterfrom
osirisinferi:add-HSE-to-DakeFPV405
Feb 19, 2026
Merged

Add SYSTEM_HSE_MHZ define to DAKEFPVF405 target#1032
haslinghuis merged 1 commit intobetaflight:masterfrom
osirisinferi:add-HSE-to-DakeFPV405

Conversation

@osirisinferi
Copy link
Contributor

@osirisinferi osirisinferi commented Feb 19, 2026

Board contains an 8 MHz ceramic resonator, physically verified.

Summary by CodeRabbit

  • Chores
    • Configured external oscillator frequency to 8 MHz for system clock operations.

Board contains an 8 MHz ceramic resonator, physically verified
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

A single preprocessor macro SYSTEM_HSE_MHZ with value 8 has been added to the DAKEFPVF405 board configuration header file, alongside existing system and clock-related definitions.

Changes

Cohort / File(s) Summary
Configuration Update
configs/DAKEFPVF405/config.h
Added SYSTEM_HSE_MHZ preprocessor macro set to 8 for system clock configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Bugfix

Suggested reviewers

  • haslinghuis
  • ot0tot
  • nerdCopter
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is significantly incomplete. It lacks the mandatory sections from the template including hardware compliance requirements, design guidelines adherence, and the required checklist items. Update the description to include all mandatory template sections: hardware compliance requirements, design guidelines attestation, and completed checklist items for schematic review, hardware testing, guidelines adherence, connector standards, flight testing, and issue resolution.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding a SYSTEM_HSE_MHZ define to the DAKEFPVF405 target configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis added the Bugfix Fixes a problem label Feb 19, 2026
@haslinghuis haslinghuis merged commit 1350af3 into betaflight:master Feb 19, 2026
5 checks passed
@osirisinferi osirisinferi deleted the add-HSE-to-DakeFPV405 branch February 19, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants