Skip to content

Add SYSTEM_HSE_MHZ definition to ACCI F405#1033

Merged
haslinghuis merged 1 commit intobetaflight:masterfrom
jesuslg123:Enable-ACCI-F405-HSE
Feb 20, 2026
Merged

Add SYSTEM_HSE_MHZ definition to ACCI F405#1033
haslinghuis merged 1 commit intobetaflight:masterfrom
jesuslg123:Enable-ACCI-F405-HSE

Conversation

@jesuslg123
Copy link
Contributor

@jesuslg123 jesuslg123 commented Feb 19, 2026

The board contains an external resonator

Pull-Request requirements

Mandatory Review for All New Flight Controllers

  • All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
  • Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

  • Pull-Request only from a custom branch, not master.
  • Replace this text with details of your own.

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • Chores
    • Added new system configuration parameter to the defaults configuration.

The board contains an external resonator
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

A single preprocessor macro definition SYSTEM_HSE_MHZ with value 8 was added to the ACCIF405 board configuration header file. This addition provides the missing HSE (High Speed External oscillator) frequency definition for the ACCIF405 target.

Changes

Cohort / File(s) Summary
Board Configuration
configs/ACCIF405/config.h
Added SYSTEM_HSE_MHZ macro definition set to 8 MHz, specifying the external crystal oscillator frequency for ACCIF405.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Suggested labels

Bugfix

Suggested reviewers

  • nerdCopter
  • ot0tot
  • haslinghuis
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete. It provides only a brief explanation ('The board contains an external resonator') but retains the template boilerplate and leaves all checklist items unchecked without providing the required project-specific details. Replace template boilerplate with actual PR details: explain the external resonator specs, describe hardware/testing status, and check/document relevant checklist items (schematics review, hardware testing, guidelines compliance, connector standards, flight testing, and resolution of any comments).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a SYSTEM_HSE_MHZ definition to the ACCI F405 board configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis added the Bugfix Fixes a problem label Feb 19, 2026
@haslinghuis haslinghuis merged commit a8783ef into betaflight:master Feb 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants