Add support for LSM6DSK320X gyroscope to existing targets#1040
Add support for LSM6DSK320X gyroscope to existing targets#1040Greypang wants to merge 23 commits intobetaflight:masterfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (14)
WalkthroughThis PR adds preprocessor macros to enable LSM6DSK320X accelerometer/gyroscope support across 14 GEPRC flight controller board configuration files. Some configurations additionally enable BMI270 support. All changes are feature flag additions with no logic modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I don't think we can add this gyro to targets with GYRO_CLKIN defined, as the LSM6DSK320X does not support gyro clock. Presumably they are using the same FC footprint, so this will provide a 32kHz clock signal on INT2 which the LSM6DSK320X does not expect. I'm not sure what the behavior will be in this case. |
|
@ot0tot verified with firmware - GYRO_CLKIN is only used in 426xx driver. |
|
Maybe add ifdefs for CLIKIN based on defines for the ICM-42688-P? Not sure what the best approach would be tbh. |
Add support for LSM6DSK320X gyroscope to existing targets
Summary by CodeRabbit