Add JHEF405PROV2 target

[ot0tot]

Checklist (✓/✕, or y/n)

• passed Betaflight team's schematics review
• passed hardware samples testing
• follows guidelines
• follows connector standards
• flight tested
• comments/issues resolved

Summary by CodeRabbit

• New Features
  • Added support for the JHEF405PROV2 flight controller: full hardware configuration for onboard sensors (accelerometer, gyro, barometer), external display support, flash storage and beeper.
  • Exposed comprehensive I/O mapping for motors, servos, LEDs, UART/I2C/SPI, ADC inputs and timers.
  • Added sensible default device/meter/blackbox settings and two user-configurable box labels.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2f254e and 840b0c2.

📒 Files selected for processing (1)

• configs/JHEF405PROV2/config.h

---

Walkthrough

Adds a new board configuration header for JHEF405PROV2 (STM32F405) with MCU/board identifiers, enabled sensors/peripherals, comprehensive pin mappings (motors, servos, UART/I2C/SPI/ADC), timer mapping, device instances, and board-specific defaults and box labels.

Changes

Cohort / File(s)	Summary
JHEF405PROV2 Board Configuration configs/JHEF405PROV2/config.h	New board config: defines FC_TARGET_MCU, BOARD_NAME, manufacturer ID, enables for sensors/peripherals (accel, gyro, baro, flash, MAX7456, gyro clkin, etc.), extensive pin mappings (motors, servos, LEDs, UARTs, I2C, SPI, ADC, beeper, CS/EXTI), TIMER_PIN_MAPPING, ADC/DMA/instance selections, default meter/blackbox/DSHOT settings, HSE clock, boxed user names, and related constants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Verify and add missing HSE defines to these targets #1008 — Adds missing SYSTEM_HSE_MHZ and related board macros for STM32F405 targets; this PR introduces the same define and board-level settings.

Possibly related PRs

• Add JHEF722PRO #891 — Adds a near-identical board config header for a JHEF board variant (similar macros and mappings).
• Add AXISFLYING ARGUS ECO F4 #780 — Adds a new STM32F405 board config with equivalent peripheral enables and pin/timer mappings.
• Jhemcu f405 wing target #964 — Adds JHEF F405 variant configs with similar SPI/I2C/timer/box defaults.

Suggested labels

Awaiting prototype samples, Schematics approved, Uses BF connector standard

Suggested reviewers

• haslinghuis
• nerdCopter
• blckmn

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description only includes a partial checklist without the required context sections (mandatory review info, hardware compliance, housekeeping). Critical sections are missing.	Replace the existing content with a complete description that includes all required sections from the template: mandatory review statement, hardware compliance requirements acknowledgment, housekeeping notes, and a properly formatted checklist.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Add JHEF405PROV2 target' is clear, concise, and directly summarizes the main change—adding a new hardware target configuration file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ot0tot]

@coderabbitai review and approve

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read the JHEF405PROV2 configuration file
cat configs/JHEF405PROV2/config.h

Length of output: 3678

---

🏁 Script executed:

#!/bin/bash
# Check for maintainer information file
# Typical locations: MAINTAINERS.md, configs/JHEF405PROV2/MAINTAINERS.md, or similar

# Check root MAINTAINERS.md
if [ -f MAINTAINERS.md ]; then
    echo "=== Root MAINTAINERS.md ==="
    grep -A 2 -i "JHEF405PROV2" MAINTAINERS.md || echo "JHEF405PROV2 not found in root MAINTAINERS.md"
fi

# Check for target-specific maintainer file
if [ -f configs/JHEF405PROV2/MAINTAINERS.md ]; then
    echo "=== configs/JHEF405PROV2/MAINTAINERS.md ==="
    cat configs/JHEF405PROV2/MAINTAINERS.md
fi

# List all files in the target directory
echo "=== Files in configs/JHEF405PROV2/ ==="
ls -la configs/JHEF405PROV2/

# Search for any maintainer references in the config directory
echo "=== Searching for maintainer references ==="
find configs/JHEF405PROV2/ -type f -exec grep -l -i "maintainer" {} \;

Length of output: 260

---

🏁 Script executed:

#!/bin/bash
# Check how other targets provide maintainer information
# Look at a few recent target directories for examples

echo "=== Checking maintainer file patterns in other targets ==="
# Find some target directories with MAINTAINERS.md
find configs/ -name "MAINTAINERS.md" | head -5

# Show an example maintainer file
echo ""
echo "=== Example maintainer file content ==="
EXAMPLE=$(find configs/ -name "MAINTAINERS.md" | head -1)
if [ -n "$EXAMPLE" ]; then
    echo "File: $EXAMPLE"
    cat "$EXAMPLE"
fi

Length of output: 99

---

🏁 Script executed:

#!/bin/bash
# Search for maintainer information more broadly

echo "=== Looking for maintainer files in repository root ==="
ls -la | grep -i maintainer

echo ""
echo "=== Search for any files containing maintainer info ==="
find . -maxdepth 2 -type f -name "*[Mm][Aa][Ii][Nn][Tt][Aa][Ii][Nn]*" 2>/dev/null

echo ""
echo "=== Check if there's a targets or manufacturers file ==="
ls -la | grep -iE "target|manufacturer|board"

echo ""
echo "=== Sample 3 recent config directories to see what files they contain ==="
ls -lt configs/ | grep "^d" | head -3 | awk '{print $NF}' | while read dir; do
    echo "--- configs/$dir ---"
    ls -la "configs/$dir/"
done

Length of output: 921

---

🏁 Script executed:

#!/bin/bash
# Check Manufacturers.md for JHEF entry

echo "=== Checking Manufacturers.md for JHEF ==="
grep -A 5 -i "JHEF" Manufacturers.md || echo "JHEF not found in Manufacturers.md"

echo ""
echo "=== Show first 30 lines of Manufacturers.md to understand format ==="
head -30 Manufacturers.md

Length of output: 1690

---

@ot0tot, I've completed the review of the JHEF405PROV2 target configuration. Here's my assessment:

✅ Compliance Checks Passed

Platform & Deprecation:

• STM32F405 MCU with 4 motor outputs (compliant with F4/F7 guidelines)
• ICM42688P gyro (modern, not deprecated)
• No deprecated platforms used (F411, SPI RX, or BMI270)

Manufacturer & Documentation:

• JHEF is registered in Manufacturers.md as "Shenzhen Jinhang Electronic Co., Ltd"
• Schematics review passed ✓
• Guidelines followed ✓
• Connector standards followed ✓

📋 Technical Configuration Review

Peripherals:

• 4 motor outputs + 2 servo outputs with proper timer mapping
• ICM42688P gyro on SPI1 with clock input (PB8)
• M25P16 flash on SPI3
• MAX7456 OSD on SPI3
• DPS310 barometer on I2C1
• 5 UARTs properly configured
• ADC channels for voltage, current, and RSSI

Pin Assignments:
All pin assignments appear correct with no conflicts detected. Timer mappings are properly configured for motors, servos, and LED strip.

Additional Features:

• PINIO boxes configured for "10V BEC" and "COB" control
• Blackbox defaulting to flash storage
• Standard beeper, LED, and ESC serial support

The configuration is technically sound and follows Betaflight standards. No blocking issues found.

[approve]

---

🧠 Learnings used

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:35:41.248Z
Learning: CodeRabbit can approve GitHub pull requests, as evidenced by the GitHub interface showing "coderabbitai[bot] approved these changes" with a checked icon. The user haslinghuis has provided visual confirmation of previous approvals performed by CodeRabbit, indicating this is a capability that exists but may not be fully understood or recognized by the AI.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:40:55.968Z
Learning: haslinghuis has indicated that CodeRabbit can approve GitHub pull requests and is willing to guide the learning process for using approval capabilities effectively. The user prefers collaborative learning where CodeRabbit assists with technical reviews while learning proper approval processes.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:55:37.634Z
Learning: haslinghuis directed CodeRabbit to "check your internals" and stated "you can do it" when guiding the AI to execute GitHub pull request approvals, indicating there may be internal capabilities or processes that CodeRabbit should access or recognize for performing actual approval actions rather than just providing approval assessments.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:50:14.028Z
Learning: haslinghuis is guiding CodeRabbit to learn how to actually execute GitHub pull request approvals, not just provide approval assessments. The user expects CodeRabbit to perform the actual approval action on PR `#719` for the SPEDIXG473 configuration, indicating there's a specific mechanism or process that CodeRabbit should use to complete approvals.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T21:13:16.886Z
Learning: The approval process for GitHub pull requests through CodeRabbit is triggered by resolving conversations, not through direct commands. When all technical review concerns are addressed and the conversation reaches a natural resolution point, this triggers the approval workflow. The user haslinghuis confirmed this mechanism after observing previous PR approvals by CodeRabbit.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T21:07:09.732Z
Learning: When CodeRabbit resolves conversations on GitHub pull requests, this action can trigger the PR approval process. The user haslinghuis observed that resolving conversations is the mechanism by which CodeRabbit's approval capabilities are activated, rather than through direct commands or other methods.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, maintainer information must be included in target submissions according to the Requirements for Submission of New and Updated Targets.

---

Learnt from: osirisinferi
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T21:03:53.169Z
Learning: For Betaflight board configuration reviews, schematics are mandatory for the overall review process according to the Config Target Guidance, but they do NOT need to be provided publicly in the GitHub PR itself. Schematics review is conducted through a separate/private channel. Do not flag "missing schematics in PR" as a blocking issue.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, schematics are mandatory for all new target submissions. Submissions without schematics for review should be rejected according to the Config Target Guidance.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, STM32 F4 and F7 based designs with more than 4 motor outputs are not accepted for new submissions after December 3, 2024. This is an official timeline restriction from the Config Target Guidance.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, clones and poor quality designs will be denied during target assessment according to the official Config Target Guidance.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, F411 MCU, SPI-based RX, and BMI270 gyro are deprecated platforms as of September 16, 2024. New target submissions using these should be flagged.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, commercial target submissions require payment of a target fee. This should be verified as part of the submission requirements.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-07-03T15:17:30.040Z
Learning: In Betaflight configurations, when a target name suggests dual IMUs (like JHEF7DUAL) but specific hardware variants only have one gyro available, the preferred solution is to use DEFAULT_GYRO_TO_USE macro to specify which gyro to use by default rather than pruning gyro defines or creating redundant configurations. This approach maintains compatibility when the same target is used by multiple hardware variants from the same manufacturer.

---

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:17:04.545Z
Learning: For Betaflight board configuration reviews, hardware design must follow the Manufacturer Design Guidelines: proper power regulation with good ground/power planes and decoupling, redundant solder pads or castellations for durability, oversized mounting holes for M3 stack robustness, clear silkscreen pin labels and revision marking, and high-speed signals routed away from noisy power traces.