Skip to content

AedroxH7. - Update config.h#1046

Closed
Aedrox-UAx wants to merge 1 commit intobetaflight:masterfrom
Aedrox-UAx:patch-1
Closed

AedroxH7. - Update config.h#1046
Aedrox-UAx wants to merge 1 commit intobetaflight:masterfrom
Aedrox-UAx:patch-1

Conversation

@Aedrox-UAx
Copy link

@Aedrox-UAx Aedrox-UAx commented Mar 3, 2026

Config file update (minor changes)

Pull-Request requirements

Mandatory Review for All New Flight Controllers

  • All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
  • Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

  • Pull-Request only from a custom branch, not master.
  • Replace this text with details of your own.

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features

    • On-Screen Display (OSD) support is now available for displaying flight information in real-time
    • Camera switch functionality has been added for convenient control
  • Improvements

    • Flash memory configuration updated for enhanced reliability
    • Hardware sensor compatibility refreshed

Config file update (minor changes)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

Caution

Review failed

Failed to post review comments

Walkthrough

Configuration updates for the AEDROXH7 board including LED pin reassignment, SPI1 interface definition, gyro chip select pin change, flash memory chip replacement from W25Q128FV/M25P16 to W25N01G, MAX7456 OSD support with dedicated pins, barometer sensor addition, and PINIO adjustments with camera switch functionality.

Changes

Cohort / File(s) Summary
AEDROXH7 Board Configuration
configs/AEDROXH7/config.h
Updated hardware pin assignments: LED1_PIN (PE4→PC13), GYRO_1_CS_PIN (PA4→PB12), added SPI1 pins (SCK/SDI/SDO on PB3/PB4/PB5). Replaced flash memory support (W25Q128FV/M25P16→W25N01G). Added MAX7456 OSD with SPI1 instance and PE4 CS pin. Added DPS368 barometer. Modified PINIO3_PIN (PB12→PB1), added PINIO4_PIN (PD15) with box assignment 43 for camera switch.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • haslinghuis
  • ot0tot
  • nerdCopter
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only a placeholder statement 'Config file update (minor changes)' followed by boilerplate template text that was not replaced with actual PR details as instructed. Replace the placeholder text with specific details about the hardware changes (SPI1 pins, OSD support, flash memory updates, etc.) and complete the checklist items to indicate review status.
Title check ❓ Inconclusive The title is vague and generic—'Update config.h' does not specify which config or what changes were made, making it unclear to reviewers scanning history. Replace with a more specific title like 'AedroxH7: Update config with SPI1, OSD, and barometer support' to clearly describe the main changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Aedrox-UAx Aedrox-UAx changed the title Update config.h AedroxH7. - Update config.h Mar 3, 2026
@ot0tot
Copy link
Contributor

ot0tot commented Mar 3, 2026

These changes are invalid. Please read and follow the Betaflight manufacturer design guidelines (https://www.betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines).

@ot0tot ot0tot closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants