Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds a new Betaflight board configuration header for OXBOT_FLOW_AIO45 defining MCU, board identifiers, enabled peripherals, pin and timer mappings, sensor/SPI/I2C instances, and default runtime/telemetry settings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
|
We'll send samples next week. |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@configs/OXBOT_FLOW_AIO45/config.h`:
- Around line 79-84: The TIMER_PIN_MAPPING has incorrect timer indices: update
the entry for MOTOR3_PIN in TIMER_PIN_MAPPING (currently using TIMER_PIN_MAP
with timer 1) to use timer 2 instead, and update the entry for GYRO_1_CLKIN_PIN
(currently using timer 3) to use timer 1 so the mappings for MOTOR3_PIN and
GYRO_1_CLKIN_PIN match the AT32F435 pin-to-timer mappings; adjust the two
TIMER_PIN_MAP calls accordingly in the TIMER_PIN_MAPPING macro.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2dd52d6d-6d58-493a-9e5f-e922c8dbec4f
📒 Files selected for processing (1)
configs/OXBOT_FLOW_AIO45/config.h
configs/OXBOT_FLOW_AIO45/config.h
Outdated
| #define TIMER_PIN_MAPPING TIMER_PIN_MAP(0, MOTOR1_PIN, 1, 1) \ | ||
| TIMER_PIN_MAP(1, MOTOR2_PIN, 1, 2) \ | ||
| TIMER_PIN_MAP(2, MOTOR3_PIN, 2, 3) \ | ||
| TIMER_PIN_MAP(3, MOTOR4_PIN, 2, 4) \ | ||
| TIMER_PIN_MAP(4, LED_STRIP_PIN, 1, 5) \ | ||
| TIMER_PIN_MAP(5, GYRO_1_CLKIN_PIN, 1, -1) |
There was a problem hiding this comment.
LS conflicts with M2 and GYRO_CLKIN
| Pin | Resource | 1 | 2 | 3 | Preferred |
|---|---|---|---|---|---|
| PB6 | M1 | TIM4-CH1 | 1 | ||
| PB9 | M2 | TIM2-CH2 | TIM4-CH4 | TIM11-CH1 | 2 |
| PB1 | M3 | X | TIM3_CH4 | X | 2 |
| PB0 | M4 | X | TIM3_CH3 | X | 2 |
| PB11 | LS | TIM2-CH4 | TIM5-CH4 | 2 | |
| PA2 | GC | TIM2-CH3 | TIM5-CH3 | TIM9-CH1 | 3 |
| #define TIMER_PIN_MAPPING TIMER_PIN_MAP(0, MOTOR1_PIN, 1, 1) \ | |
| TIMER_PIN_MAP(1, MOTOR2_PIN, 1, 2) \ | |
| TIMER_PIN_MAP(2, MOTOR3_PIN, 2, 3) \ | |
| TIMER_PIN_MAP(3, MOTOR4_PIN, 2, 4) \ | |
| TIMER_PIN_MAP(4, LED_STRIP_PIN, 1, 5) \ | |
| TIMER_PIN_MAP(5, GYRO_1_CLKIN_PIN, 1, -1) | |
| #define TIMER_PIN_MAPPING TIMER_PIN_MAP(0, MOTOR1_PIN, 1, 1) \ | |
| TIMER_PIN_MAP(1, MOTOR2_PIN, 2 2) \ | |
| TIMER_PIN_MAP(2, MOTOR3_PIN, 2, 3) \ | |
| TIMER_PIN_MAP(3, MOTOR4_PIN, 2, 4) \ | |
| TIMER_PIN_MAP(4, LED_STRIP_PIN, 2, 5) \ | |
| TIMER_PIN_MAP(5, GYRO_1_CLKIN_PIN, 3, -1) |
Summary by CodeRabbit