Skip to content

Add CADDX_Protos_F4 config#978

Closed
CADDXFPV wants to merge 2 commits intobetaflight:masterfrom
CADDXFPV:CADDX_Protos_F4
Closed

Add CADDX_Protos_F4 config#978
CADDXFPV wants to merge 2 commits intobetaflight:masterfrom
CADDXFPV:CADDX_Protos_F4

Conversation

@CADDXFPV
Copy link

@CADDXFPV CADDXFPV commented Dec 9, 2025

Pull-Request requirements

Mandatory Review for All New Flight Controllers

  • All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
  • Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

  • Pull-Request only from a custom branch, not master.
  • Replace this text with details of your own.

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Added support for the CADDX Protos F4 flight controller: selectable IMU options, barometer support, integrated OSD and onboard flash storage, configurable motor/PWM output and LED strip, multiple UART ports including CRSF passthrough, ADC-based current/voltage sensing and beeper/LED controls.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a new STM32F405-based board configuration header for CADDX_Protos_F4 that declares MCU/board IDs, sensor and peripheral feature flags, SPI/I2C/UART/ADC pin and instance mappings, motor/LED pins, OSD and flash support, and default alignment/measurement scales. (49 words)

Changes

Cohort / File(s) Summary
CADDX_Protos_F4 Board Configuration
configs/CADDX_Parotos_F4/config.h
New configuration header for an STM32F405 target: defines FC_TARGET_MCU, BOARD_NAME, MANUFACTURER_ID; enables sensors (gyro/accel: MPU6000/MPU6500/ICM42688P/BMI270, baro: BMP280/DPS310), OSD (MAX7456), flash (W25Q128FV), CRSF RX; provides SPI/I2C/UART pin & instance mappings, PWM/motor/timer mapping, ADC/current/voltage pins and scaling, LED/beeper pins, and various default macros.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify SPI1/SPI2/SPI3 pin assignments and CS pins for sensor/OSD/flash for conflicts.
  • Confirm UART mappings (GPS, MSP/DisplayPort, CRSF passthrough) match schematic.
  • Check ADC pin assignments, current/voltage source selection, and scaling constants.
  • Validate sensor selection macros and alignment/default yaw orientation.

Possibly related PRs

  • Add JHEF722PRO #891 — Adds similar board configuration headers with overlapping peripheral and pin definitions (GYRO_1_*, SPI/I2C/UART/ADC mappings).
  • Add AXISFLYING ARGUS ECO F4 #780 — Adds an STM32F405 board configuration header with nearly identical sensor/OSD/flash and peripheral mappings.

Suggested labels

Awaiting prototype samples

Suggested reviewers

  • haslinghuis
  • ot0tot
  • sugaarK

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is a template placeholder that was not replaced with specific details about this submission, failing to customize required information. Replace the template with specific details about your CADDX_Protos_F4 hardware, configuration decisions, and mark the checklist items based on your actual compliance status.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add CADDX_Protos_F4 config' directly and clearly describes the main change: adding a new configuration header for the CADDX_Protos_F4 flight controller.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ot0tot ot0tot added the Contact Betaflight Team cloudtargets@betaflight.com label Dec 9, 2025
@ot0tot
Copy link
Contributor

ot0tot commented Dec 10, 2025

@CADDXFPV Please contact Betaflight. This FC does not follow the manufacturer design guidelines, and cannot be accepted as-is. Please also review the PR requirements in the first comment.

@CADDXFPV CADDXFPV closed this Dec 10, 2025
@SteveCEvans
Copy link
Member

I think this was the wrong approach. The attached contains an update to the CADDXF4_AIO_ELRS_V2 config file which makes as many changes as possible there and also contains a configuration file specific to the Protos.

CaddxProtos.zip

I believe we should have a config file that enables all the device support needed and then a preset for the model itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contact Betaflight Team cloudtargets@betaflight.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants