Conversation
|
Caution Review failedFailed to post review comments WalkthroughAdds a new STM32F405-based board configuration header for CADDX_Protos_F4 that declares MCU/board IDs, sensor and peripheral feature flags, SPI/I2C/UART/ADC pin and instance mappings, motor/LED pins, OSD and flash support, and default alignment/measurement scales. (49 words) Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CADDXFPV Please contact Betaflight. This FC does not follow the manufacturer design guidelines, and cannot be accepted as-is. Please also review the PR requirements in the first comment. |
|
I think this was the wrong approach. The attached contains an update to the CADDXF4_AIO_ELRS_V2 config file which makes as many changes as possible there and also contains a configuration file specific to the Protos. I believe we should have a config file that enables all the device support needed and then a preset for the model itself. |
Pull-Request requirements
Mandatory Review for All New Flight Controllers
Hardware Compliance Requirements
These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.
If you have any questions or need guidance, feel free to reach out to the Betaflight development team.
Housekeeping
master.Checklist (✓/✕, or y/n)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.