Migration jest => vitest WIP #4806
Open
+13,358
−14,181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shamzic
force-pushed
the
migration-jest-into-vitest
branch
from
3314332 to
cc3caad
Compare
jenovateurs
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Super travail, merci @Shamzic .
Juste quelques petites questions mais sur le fond ok.
Il y a aussi la question de la vulnérabilité avec glob mais bon c'est pour du test, ça devrait le faire.
| @@ -109,7 +125,7 @@ describe("benefit descriptions", function () { | |||
| .replace(/\s\s+/g, " ") | |||
| .trim() | |||
| expect(innerText.length).toBeGreaterThanOrEqual(10) | |||
| expect(innerText.length).toBeLessThanOrEqual(420) | |||
| expect(innerText.length).toBeLessThanOrEqual(550) | |||
There was a problem hiding this comment.
Tu as fait un upgrade par rapport à mes aides vélos ?
| environment: "jsdom", | ||
| include: ["tests/**/*.spec.ts"], | ||
| exclude: [ | ||
| "tests/unit/views/fiscales.spec.ts", |
There was a problem hiding this comment.
Pourquoi les exclure ?
jenovateurs
requested changes
Jan 29, 2025
| "test": "NODE_OPTIONS=--experimental-vm-modules NODE_PATH=. jest --testTimeout=20000", | ||
| "test": "NODE_OPTIONS='--max-old-space-size=4096' vitest run --pool=forks --poolOptions.threads.singleThread", | ||
| "test:coverage": "vitest run --coverage", | ||
| "test:ui": "vitest --ui", |
There was a problem hiding this comment.
La commande ne fonctionne pas, j'ai du installer @vitest/ui mais il ne trouve pas la dépendance. Je propose de le supprimer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite aux difficulté de compatibilité de Jest avec la version de vue 3.5, je propose de migrer les tests unitaires avec la lib Vitest qui me semble plus à jour et car c'est aussi la recommandation par défaut du framework.
À investiguer: