fix(front): fix blue banner when content is small #1789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
L'indentation est chelou
There was a problem hiding this comment.
c'était un Quick fix car de base l'idée de mettre le fond sur les marges demandait de placer le style assez haut dans l'arbre HTML. J'ai juste rajouté un étage de balise englobant header et content pour ne pas avoir de fond bleu sur le footer.
Ceci dit aucun pb d'indentation sur safari et même en mode mobile et tablette.
Je vérifierai lundi
There was a problem hiding this comment.
Je parle de l'indentation du code pas sur le rend final
|
j'en refais une depuis develop avec d'autres correctifs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #849