Valide automatiquement les déclarations ayant des doublons du snapshot "SUBMIT" #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1395
Contexte
Précédemment la validation automatique des déclarations prenait seulement celles ayant un seul snapshot de type "SUBMIT". Or, il arrive des cas où un·e admin doit remettre une déclaration en état brouillon et le pro refait la soumission. La déclaration se trouve donc avec deux snapshots de type "SUBMIT" et n'est plus validé automatiquement.
Scope
Un léger changement de l'algo fait que les déclarations ayant seulement des snapshots de type "SUBMIT" sont prises pour la validation automatique.
Çad, si une déclaration a deux (ou trois, ou quatre) snapshots mais qu'ils sont tous de type "SUBMIT", elle sera validée automatiquement - si les autres critères sont remplis bien sûr.
Mais dès que la déclaration contient au moins un snapshot d'un type différent à "SUBMIT", la déclaration n'est plus considérée pour la validation automatique.