Change the files context service url in config and change rule accord…

…ion label
betagouv · Dec 6, 2024 · 9e6b995 · 9e6b995
1 parent 78df8a3
commit 9e6b995
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/.../api/src/reports-context/adapters/secondary/gateways/services/http-report-file-service.ts b/.../api/src/reports-context/adapters/secondary/gateways/services/http-report-file-service.ts
@@ -15,8 +15,6 @@ export class HttpReportFileService implements ReportFileService {
     this.fileServiceUrl = new URL(
       this.apiConfig.contextServices.filesContext.baseUrl,
     );
-    this.fileServiceUrl.port =
-      this.apiConfig.contextServices.filesContext.port.toString();
   }
 
   async uploadFile(

diff --git a/apps/api/src/shared-kernel/adapters/primary/nestjs/env.ts b/apps/api/src/shared-kernel/adapters/primary/nestjs/env.ts
@@ -10,8 +10,9 @@ export const apiConfig: ProdApiConfig = {
   },
   contextServices: {
     filesContext: {
-      baseUrl: 'http://localhost',
-      port: 3000,
+      // The DNS will resolve this url to a private IP.
+      // APP env variable is set by scalingo.
+      baseUrl: `http://${process.env.APP}.osc-secnum-fr1.scalingo.io`,
     },
   },
   s3: {
@@ -43,8 +44,7 @@ export const defaultApiConfig = {
   },
   contextServices: {
     filesContext: {
-      baseUrl: 'http://localhost',
-      port: 3000,
+      baseUrl: 'http://localhost:3000',
     },
   },
   s3: {

diff --git a/apps/api/src/shared-kernel/adapters/primary/zod/api-config-schema.ts b/apps/api/src/shared-kernel/adapters/primary/zod/api-config-schema.ts
@@ -5,7 +5,6 @@ const commonBaseSchema = z.object({
   contextServices: z.object({
     filesContext: z.object({
       baseUrl: z.string(),
-      port: z.number(),
     }),
   }),
 });

diff --git a/apps/webapp/src/reports/core-logic/builders/ReportVMRules.builder.ts b/apps/webapp/src/reports/core-logic/builders/ReportVMRules.builder.ts
@@ -85,7 +85,7 @@ export const getReportAccordionLabel = (
     case NominationFile.RuleGroup.STATUTORY:
       return "Autres règles statutaires";
     case NominationFile.RuleGroup.QUALITATIVE:
-      return "Autres règles qualitatives";
+      return "Autres éléments qualitatifs";
     default: {
       const _exhaustiveCheck: never = group;
       console.info(_exhaustiveCheck);