fix: add .js extension to bin file for ESM compatibility #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ERR_UNKNOWN_FILE_EXTENSION error when running snapai with Node.js 18+. The package uses "type": "module" but the bin file lacked a file extension, which is required for ES modules in Node.js. Changes: - Renamed bin/snapai to bin/snapai.js - Updated package.json bin field to point to ./bin/snapai.js - Updated files array to include bin/snapai.js Tested with Node.js v20.5.0 and v16.20.2 - both work correctly after fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ERR_UNKNOWN_FILE_EXTENSION error when running snapai with Node.js 18+. The package uses "type": "module" but the bin file lacked a file extension, which is required for ES modules in Node.js.
Changes:
Tested with Node.js v20.5.0 and v16.20.2 - both work correctly after fix.