You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR migrates both better-fetch and logger packages from tsup to tsdown (rolldown-based) and bumps TypeScript from ^5.x to ^6.0.3. A small explicit return-type annotation is added to getTimeout in utils.ts to satisfy TypeScript 6's stricter inference requirements.
Build tool migration: tsdown.config.ts files replace tsup.config.ts across both packages, mapping external → deps.neverBundle and adding target: "es2017" / platform: "neutral". Default output extensions (.js for ESM, .cjs for CJS) align with the exports fields in each package.json.
TypeScript 6 compatibility: tsconfig.json files updated with lib: ["ES2022", "DOM"] and moduleResolution: "bundler" where needed; packages/logger/tsconfig.json switches module from "commonjs" to "ESNext" and adds customConditions: ["node"].
Toolchain centralization: tsdown is declared only in the root package.json rather than in each package's own devDependencies (unlike the previous tsup setup), relying on pnpm workspace hoisting for resolution.
Confidence Score: 5/5
Safe to merge; the tooling changes are mechanical and the output file paths produced by tsdown's defaults correctly match the exports fields in both packages.
The build configs produce the correct ESM/CJS output extensions without any outExtensions override, the tsconfig changes are consistent with TypeScript 6 requirements, and the explicit return-type annotation in utils.ts is accurate. No logic changes to library code are introduced.
packages/better-fetch/package.json and packages/logger/package.json no longer declare tsdown locally (unlike the previous tsup entries); this relies on pnpm workspace hoisting and is worth keeping an eye on if the packages are ever built in an isolated context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs already need updates and aren't currently deployed automatically, so I left them unchanged in this PR