Skip to content

Feat/reporting#271

Open
IamIsthill wants to merge 15 commits intobettergovph:mainfrom
IamIsthill:feat/reporting
Open

Feat/reporting#271
IamIsthill wants to merge 15 commits intobettergovph:mainfrom
IamIsthill:feat/reporting

Conversation

@IamIsthill
Copy link
Contributor

@IamIsthill IamIsthill commented Sep 25, 2025

#207

  • format issue fixed

@IamIsthill IamIsthill marked this pull request as ready for review September 25, 2025 13:25
@IamIsthill
Copy link
Contributor Author

IamIsthill commented Sep 25, 2025

Please review @mayspc @codegino

codegino
codegino reviewed Sep 25, 2025
View reviewed changes
codegino
codegino previously approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@codegino codegino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried on my local and didn't see any obvious issues. Will wait for others to double confirm.

aluminyoom
aluminyoom requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@aluminyoom aluminyoom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently introduces a library clash

src/components/ui follows different conventions. and there are 2 files with the same name but different capitalization with different contents

Dialog.tsx (existing)
dialog.tsx (this pr)

either we:

  1. move this into its own folder
  2. move the existing components into its own folder
  3. use the existing components
  4. use the new shadcn components

eitherway, this will set the direction of the repo forward.

Let's postpone this until after the Design Meeting tomorrow.

@IamIsthill
Copy link
Contributor Author

IamIsthill commented Sep 25, 2025

src/components/ui follows different conventions. and there are 2 files with the same name but different capitalization with different contents

Haven't really noticed this. I think it was caused by shad/cn, then another member creating that same component afterwards

@IamIsthill
refactor(hotline-data): move all hotline data handling in a separate …
ba9109b 
…folder
@IamIsthill
feat: add UI components for dialog, form, input, label, select, sonne…
05587f8 
…r, and tooltip
@IamIsthill
feat: add mailer API hook for outdated hotline reports
6b33929
@IamIsthill
feat: add ReportModal component for submitting outdated hotline reports
2900959
@IamIsthill
feat: implemented the Outdated Hotline Feature
f34fd22
@IamIsthill
refactor: replace axios with fetch API in useMailerApi hook
e529118 
- Removed axios dependency from package.json.
- Updated useMailerApi to use the fetch API instead of axios for making API calls.
- Adjusted error handling and response parsing to accommodate the new fetch implementation.
@IamIsthill
fix: enable send button after failed send
a67e1e3
@IamIsthill
refactor: remove unnecessary typings and simplify hooks
7641dc3 
- Add user friendly error
@IamIsthill
feat: added styles to the base form and select
bc9352c
@IamIsthill
fix: resolve the issue of overflowing contents on the modal
4f0fbfc
@IamIsthill
refactor: separated form component into hook, context files, and ui
cfd4d3c
@IamIsthill
refactor: use nonempty
218978f
@IamIsthill
refactor: use upstream dialog implementation
bfc1353
@IamIsthill
fix: format ui compoents
a7d3133
@IamIsthill
fix: use single quotes
17489d9
@IamIsthill
Copy link
Contributor Author

IamIsthill commented Sep 29, 2025

@mayspc

@aluminyoom
Copy link
Member

aluminyoom commented Sep 29, 2025

Hi! Let's stick to using the existing deisgn system for now, shadcn is currently causing conflicts with the files (specifically Dialog.tsx)

@angelofallars angelofallars added enhancement New feature or request good first issue Good for newcomers low priority This project can take it easy, no to long deadline. and removed good first issue Good for newcomers labels Oct 16, 2025
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aluminyoom aluminyoom aluminyoom requested changes

@codegino codegino codegino left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request low priority This project can take it easy, no to long deadline. no-pr-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IamIsthill @aluminyoom @codegino @angelofallars