feat: allow direct linking to city|province via url#21
Open
miconficker wants to merge 2 commits intobettergovph:mainfrom
Open
feat: allow direct linking to city|province via url#21miconficker wants to merge 2 commits intobettergovph:mainfrom
miconficker wants to merge 2 commits intobettergovph:mainfrom
Conversation
|
@miconficker is attempting to deploy a commit to the waffenffs' projects Team on Vercel. A member of the Team first needs to authorize it. |
KishonShrill
requested changes
Jan 26, 2026
Member
KishonShrill
left a comment
There was a problem hiding this comment.
Wouldn't be ?city=los%20baños&province=laguna be better than ?city=los%20baños|laguna?
Cause then, the city and province is separated by parameter instead of a | symbol.
Author
|
You're right that makes more sense! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What?
🤔 Why?
📝 Additional Notes
🏞️ Screenshots
-