feat: centralize middleware and improve routing from regex-based using TinyRouter#17
Open
vonuyvicoo wants to merge 1 commit intobettergovph:mainfrom
Open
Conversation
Collaborator
|
Lovely work. I love it. Approving it and will wait for another team member to review! @angelofallars. |
jasontorres
approved these changes
Oct 18, 2025
Collaborator
|
@vonuyvicoo can you join the discord chat as well? there's a project called Petitions by BetterGov.ph in there |
Author
|
Sure! I'll join :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
createContextintofunctions/helpers/context.tsfor reuse across routes and middleware.wrapHandler,wrapHandlerWithAuth,wrapHandlerWithConditionalAuth, andwrapHandlerWithOwnershipintofunctions/helpers/wrappers.ts, consolidating auth and ownership checks.functions/index.ts: Replaced inline wrapper and context implementations with imports from the helpers, keeping the router configuration focused and readable.Impact
Link to Issue
#18