feat: support all possible elasticapm.* settings #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated pre-commit regarding broken URLs - added bettermarks/.github git-hooks - run black on all code
- update pyramid to 1.10 and emntion it in the readme - add contibuting section to readme - update install instructions - update repo URL in setup.py
since it requires access to the distribution
saurabh2590
previously approved these changes
May 13, 2024
saurabh2590
dismissed
their stale review
Looking closely for one specific change.
saurabh2590
approved these changes
May 13, 2024
cakemanny
reviewed
May 13, 2024
|
@saurabh2590 @cakemanny since we do not pin the version in backend it will be available with the next backend change, right? |
I think you're correct there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose is to support the
elasticapm.collect_local_variablessetting, but instead of just enabling this setting I found a way to enable all possible settings.In order to have a reliable setup for changes I also applied the following changes:
https://bettermarks.atlassian.net/browse/BM-61809