Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to mend dashboard from dependency dashboards #18

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

karfau
Copy link
Member

@karfau karfau commented Apr 30, 2024

Since this config can not know what repository it is used it, I wrongly assumed I could drop only the repository part of the path. But this only works if the user is already logged in to the dashboard. Otherwise it results in a 500 error page.

By linking to the same host without any path, if you are not logged in you are asked to login, and have to find the repository logs yourself. Or use the link from any of the PRs.

Since this config can not know what repository it is used it, I wrongly assumed I could drop only the repository part of the path. 
But this only works if the user is already logged in to the dashboard.
Otherwise it results in a 500 error page.

By linking to the same host without any path, if you are not logged in you are asked to login, and have to find the repository logs yourself.
Or use the link from any of the PRs.
@karfau karfau requested a review from fraukesch April 30, 2024 21:43
@karfau karfau merged commit 0f5c37d into main Apr 30, 2024
1 check passed
@karfau karfau deleted the fix-logs-link branch April 30, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant