Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'grid' direction #481

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

alexthewilde
Copy link

Re-rolling changes from this PR

@alexthewilde
Copy link
Author

alexthewilde commented Mar 27, 2017

There seems to be an issue with the test suite or test runner. If run locally, sometimes the tests pass and sometimes not due the missing document.body.

image

This might be an issue with asynchronously loading the browser env before running the test.
In any case I don't think it's related to the changes introduced by this PR.

@alexthewilde
Copy link
Author

@bevacqua care to review if this could be merged despite the irrelevant test errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant