Remove taffy upgrade from release notes #1208
Conversation
release-content/0.14/release-notes/10690_Upgrade_to_Taffy_04.md
Outdated
Show resolved
Hide resolved
| [`taffy`](https://crates.io/crates/taffy), the UI layout crate that we rely on, has had a major update. | ||
| In addition to various bug fixes, this brings two new pieces of functionality to users of `bevy_ui`: | ||
|
|
||
| 1. `Display::Block`: use the [CSS block layout model](https://www.w3schools.com/css/css_display_visibility.asp) to layout UI nodes. Elements will start on a new line, and take up the whole width. Great for in-line images! |
There was a problem hiding this comment.
This is not great for inline images! We need "inline" layout for that. This just does vertical block layout. IMO the primary use case would be matching the layout of an existing UI ported from web. Otherwise you're better off using Flexbox.
There was a problem hiding this comment.
For inline we'll need something like linebender/parley#67 (or similar support in cosmic text)
| In addition to various bug fixes, this brings two new pieces of functionality to users of `bevy_ui`: | ||
|
|
||
| 1. `Display::Block`: use the [CSS block layout model](https://www.w3schools.com/css/css_display_visibility.asp) to layout UI nodes. Elements will start on a new line, and take up the whole width. Great for in-line images! | ||
| 2. `Overflow::Hidden`: if elements overflow their container, they will be completely hidden, rather than shown or clipped. |
There was a problem hiding this comment.
There isn't really any difference between "hidden" and "clipped" in this sentence. In Taffy difference between overflow: hidden and overflow: clip is primarily that overflow: hidden turns off the automatic minimum size of a flexbox or grid child. Again, the main benefit here is that overflow: hidden will match overflow: hidden on the web (overflow: clip is arguably often what you want but isn't widely used on the web because it's much newer than "hidden").
| @@ -1 +1,5 @@ | |||
| TODO | |||
| [`taffy`](https://crates.io/crates/taffy), the UI layout crate that we rely on, has had a major update. | |||
There was a problem hiding this comment.
Doesn't affect content in this PR (except the filename), but it's worth noting that the upgrade is now to 0.5 rather than 0.4
alice-i-cecile
changed the title
Removing entirely, per discussion with @nicoburns on Discord |
alice-i-cecile
added
S-Ready-For-Final-Review
@nicoburns, I'd appreciate your review here for correctness and context :)