Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort assets that use the latest Bevy version first #1561

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Jul 16, 2024

Motivation

Help users find up-to-date assets quicker

Fixes #760
Fixes bevyengine/bevy-assets#297

Solution

Sorts assets by the following key:

(
    // Any existing order defined in the bevy-assets metadata.
    // e.g. for "official" templates and learning material
    existing_order,
    // Uses the semver crate to compare the "version requirement" from the asset with
    // the latest Bevy version
    is_semver_compatible_with_latest_bevy,
    // If all else is equal, randomize
    random
)

@TrialDragon TrialDragon added C-Feature A new feature, making something new possible A-Assets The collection of ecosystem crates found on the Bevy Assets page S-Needs-Review labels Jul 16, 2024
Copy link
Contributor

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits.

generate-assets/src/bin/generate.rs Outdated Show resolved Hide resolved
generate-assets/src/bin/generate.rs Outdated Show resolved Hide resolved
generate-assets/src/bin/generate.rs Outdated Show resolved Hide resolved
@rparrett rparrett added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Jul 18, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 23, 2024
Merged via the queue into bevyengine:main with commit ec0198f Jul 23, 2024
10 checks passed
benfrankel added a commit to benfrankel/bevy-website that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets The collection of ecosystem crates found on the Bevy Assets page C-Feature A new feature, making something new possible S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Sorting for Assets based on Bevy Version Sort assets by most recently supported Bevy version
5 participants