Add the source name to AddSourceError::SourceIsProcessed and RemoveSourceError::SourceIsProcessed.

Author: andriyDev

crates/bevy_asset/src/io/source.rs

@@ -633,7 +633,11 @@ impl AssetSources {
                 .read()
                 .unwrap_or_else(PoisonError::into_inner);
             if *started_lock {
-                return Err(AddSourceError::SourceIsProcessed);
+                let AssetSourceId::Name(name) = source.id() else {
+                    // We created this with the AssetSourceId::Name
+                    unreachable!()
+                };
+                return Err(AddSourceError::SourceIsProcessed(name));
             }
         }
 
@@ -672,7 +676,7 @@ impl AssetSources {
                 .read()
                 .unwrap_or_else(PoisonError::into_inner);
             if *started_lock {
-                return Err(RemoveSourceError::SourceIsProcessed);
+                return Err(RemoveSourceError::SourceIsProcessed(name.clone_owned()));
             }
         }
 
@@ -704,8 +708,8 @@ impl AssetSources {
 pub enum AddSourceError {
     /// The provided asset source requires processing, and processing has already started, where adding is currently unsupported.
     // TODO: Remove this once it's supported.
-    #[error("The provided asset source requires processing, but the asset processor has already started. This is currently unsupported - sources needing to be processed can only be added at startup")]
-    SourceIsProcessed,
+    #[error("The provided asset source '{0}' requires processing, but the asset processor has already started. This is currently unsupported - sources needing to be processed can only be added at startup")]
+    SourceIsProcessed(CowArc<'static, str>),
     /// An asset source with the given name already exists.
     #[error("Asset Source '{0}' already exists")]
     NameInUse(CowArc<'static, str>),
@@ -716,8 +720,8 @@ pub enum AddSourceError {
 pub enum RemoveSourceError {
     /// The requested asset source requires processing, and processing has already started, where removing is currently unsupported.
     // TODO: Remove this once it's supported.
-    #[error("The asset source being removed requires processing, but the asset processor has already started. This is currently unsupported - sources needing to be processed can only be removed at startup")]
-    SourceIsProcessed,
+    #[error("The asset source being removed '{0}' requires processing, but the asset processor has already started. This is currently unsupported - sources needing to be processed can only be removed at startup")]
+    SourceIsProcessed(CowArc<'static, str>),
     /// The requested source is missing, so it cannot be removed.
     #[error("Asset Source '{0}' does not exist")]
     MissingSource(CowArc<'static, str>),

crates/bevy_asset/src/processor/tests.rs

@@ -1545,13 +1545,13 @@ fn fails_to_add_or_remove_source_after_processor_starts() {
     // We can't remove the source because it is processed.
     assert_eq!(
         asset_server.remove_source("custom_2"),
-        Err(RemoveSourceError::SourceIsProcessed)
+        Err(RemoveSourceError::SourceIsProcessed("custom_2".into()))
     );
 
     // We can't add a processed source, since the processor has started.
     assert_eq!(
         asset_server.add_source("custom_3", &mut create_processed_source(source_gate).0),
-        Err(AddSourceError::SourceIsProcessed)
+        Err(AddSourceError::SourceIsProcessed("custom_3".into()))
     );
 
     // However we can add unprocessed sources even after the processor has started!