Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessKit Node Re-export is Confusing with Bevy's Node #16235

Open
bushrat011899 opened this issue Nov 4, 2024 · 1 comment
Open

AccessKit Node Re-export is Confusing with Bevy's Node #16235

bushrat011899 opened this issue Nov 4, 2024 · 1 comment
Labels
A-Accessibility A problem that prevents users with disabilities from using Bevy C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Design This issue requires design work to think about how it would best be accomplished
Milestone
0.15

Comments

@bushrat011899
Copy link
Contributor

Bevy version

main/0.15 RC

Description

The bevy_a11y re-exports AccessKit's Node, but that can be confusing since bevy_ui also defines a Node. Since #16234, there is now a way to use AccessKit without importing accesskit::Node. Now that it is optional, we should reconsider the way Bevy re-exports AccessKit. For example, only re-exporting Role.

Context

This was raised by @alice-i-cecile in this Discord message.
@bushrat011899 bushrat011899 added A-Accessibility A problem that prevents users with disabilities from using Bevy C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Design This issue requires design work to think about how it would best be accomplished labels Nov 4, 2024
@bushrat011899 bushrat011899 added this to the 0.15 milestone Nov 4, 2024
@alice-i-cecile
Copy link
Member

I think we should not re-export at all here, and state in the docs that the versions must match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Accessibility A problem that prevents users with disabilities from using Bevy C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Design This issue requires design work to think about how it would best be accomplished
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
2 participants
@bushrat011899 @alice-i-cecile