-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Closed
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-DocsAn addition or correction to our documentationAn addition or correction to our documentationD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Description
In Bevy 0.17 if one of the systems in a system combinator could not be run, the combinator would exit early (using ?). This was changed in #20671 to assume invalid systems returned false, and continue with the combinator logic (using unwrap_or(false)):
bevy/crates/bevy_ecs/src/schedule/condition.rs
Line 1246 in e457025
| Ok(a(input, data).unwrap_or(false) ^ b(input, data).unwrap_or(false)) |
The example for the Combine trait does not reflect this, though:
| /// Ok(a((), data)? ^ b((), data)?) |
This example should be updated to use unwrap_or(false):
Ok(a((), data).unwrap_or(false) ^ b((), data).unwrap_or(false))Metadata
Metadata
Assignees
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-DocsAn addition or correction to our documentationAn addition or correction to our documentationD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!