ssh: verify hints match the flow that ran (manual vs 1Password) - #59
Open
keithharvey wants to merge 1 commit into
Open
ssh: verify hints match the flow that ran (manual vs 1Password)#59keithharvey wants to merge 1 commit into
keithharvey wants to merge 1 commit into
Conversation
op_ssh_verify's remediation text was hardwired to the 1Password story, so a manual-setup failure told users to check 1Password. Flavor arg picks the hints; manual flow also flags the Signing-Key-vs-Auth-Key trap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thvl3
reviewed
Jul 24, 2026
thvl3
left a comment
thvl3
left a comment
Collaborator
There was a problem hiding this comment.
why do we need a 1password flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
op_ssh_verifyis shared by the 1Password and manual SSH setup flows, but its remediation text was hardwired to the 1Password story — ajust ssh::manual-setupuser whose key GitHub rejects gets told to check what 1Password is exposing.op_ssh_verifytakes a flavor arg (opdefault,manual); each failure branch (no agent / no keys / GitHub denied) now gives flow-appropriate hints${SSH_AUTH_SOCK:-unset}so the no-agent branch can't tripset -u🤖 Generated with Claude Code