modules: economy - #8524
Draft
keithharvey wants to merge 1 commit into
Draft
Conversation
keithharvey
marked this pull request as draft
July 28, 2026 21:01
Contributor
Integration Test Results17 tests ±0 8 ✅ ±0 16s ⏱️ ±0s For more details on these failures, see this check. Results for commit 9568398. ± Comparison against base commit 54c328d. ♻️ This comment has been updated with latest results. |
Waterfill answers a question that is not about allies at all: given a pool, a set of claimants and their capacities, how much does each get. It sat inside transfer because allied resource sharing is what asks it today. The one thing that tied it to transfer was a tax lookup, so the tax rule arrives as a parameter now and the solver has no opinion about what a transfer costs. Nothing else here knows who is sharing with whom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waterfill answers a question that is not about allies at all: given a pool, a set of claimants and their capacities, how much does each get. It sat inside transfer because allied resource sharing is what asks it today.
The one thing tying it to transfer was a tax lookup, so the tax rule arrives as a parameter now and the solver has no opinion about what a transfer costs. Nothing else here knows who is sharing with whom.