missions: CM8 Ashfall under pressure

[keithharvey]

The mission gains scavenger waves, and everything the mission needed in order to ask for them.

The pressure arc

Four beats in cm8_ashfall/triggers/waves.lua: open quiet half a minute in, climb when the outpost is relieved, spike when the enclave is found, stop when the commander dies. It names a pack — scavengers.skirmish — and the missions module resolves it through the scavengers module's mission vocabulary, so a mission gets the same wave director a multiplayer game runs, at a tenth of the intensity, with no bot on the field to activate it.

.After(seconds)

New, and what makes the opening beat possible. A trigger holds its effects until its conditions have gone on being true for that long, re-arming each time it fires so a repeating trigger reads as a rate limit. Seconds, never frames: MissionSeconds is a declared alias, so every editor deriving slots from the types can name the unit instead of showing a bare number.

Transfer.Give is repaired here, because CM8 is what proved it broken

Its contract is that no policy question is asked — the game moving a base, not a team choosing to share. But the move goes through Spring.TransferUnit, which fires AllowUnitTransfer, which the controller answers from the same sharing policy as any ordinary share. So the bypass bypassed nothing, and the policy gave the right answer to the wrong question: Gaia is nobody's ally, refuse.

The opening beat of this mission is "you inherit this failing base". What the player actually inherited was six structures that never moved and an enclave that shot at them. The give now announces itself for the duration of the move, the same way /take already did — a rules param rather than an upvalue, because VFS.Include is uncached and the controller and the caller hold different copies of api.lua.

The editor learns to watch

A trigger publishes that it has FIRED — not that its condition is true, which would flicker back off on a once-trigger — and both editors shade a card that has fired. That is the difference between a list of rules and a visible run through them. Wave progress is published the same way, so a director's clocks are readable from a panel.

One guard the combat module needed for the same reason waves did

The gadget handler defers its callin-list updates while iterating but nils the method field immediately, so unhooking from inside a callin takes the whole gadget down on the next frame.

Tests

CM8 needs an enemy team to arm at all, which the shared headless startscript does not have, so the scenario brings its own. test_waves.lua drives the whole arc bot-free; test_outpost.lua is the one that fails for thirty seconds without the Give fix. Both self-skip everywhere else.

---

Stacked on #8577 (scavengers) → #8576 (waves) → #8494 (cm8-ashfall).

Note for review: this commit bundles more than its title suggests — the Transfer.Give fix, .After/MissionSeconds, the fired-trigger shading and the combat callin guard are all separable if you would rather they landed as their own units.

[github-actions]

Integration Test Results

23 tests  +2    8 ✅ ±0   16s ⏱️ ±0s
 1 suites ±0   11 💤 +2 
 1 files   ±0    4 ❌ ±0 

For more details on these failures, see this check.

Results for commit 52f7acc. ± Comparison against base commit 4484c4c.

♻️ This comment has been updated with latest results.

[keithharvey]

Folded into #8494 — CM8 Ashfall is now one commit covering both the roster and the pressure arc, on the same cm8-ashfall branch. Closing this in favour of that PR; no content is lost (the resulting tree is unchanged).