Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/onedrive): Move services onedrive back #922

Merged
merged 9 commits into from
Oct 21, 2021
Merged

feat(services/onedrive): Move services onedrive back #922

merged 9 commits into from
Oct 21, 2021

Conversation

Joey-1445601153
Copy link
Contributor

Move services onedrive back to go-storage.

@Joey-1445601153
Copy link
Contributor Author

Joey-1445601153 commented Oct 20, 2021 •
edited
Loading

@Xuanwo I check the 1password. we don't have onedrive test account too.So it's a problem that has happend?
Maybe we should handle it like obs?

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 20, 2021

@Xuanwo I check the 1password. we don't have onedrive test account too.So it's a problem that has happend? Maybe we should handle it like obs?

Yes. Can you create an issue about it like #918 and leave a comment at #920?

@Joey-1445601153
Copy link
Contributor Author

Joey-1445601153 commented Oct 21, 2021 •
edited
Loading

@Xuanwo I check the 1password. we don't have onedrive test account too.So it's a problem that has happend? Maybe we should handle it like obs?

Yes. Can you create an issue about it like #918 and leave a comment at #920?

Got it.

JinnyYi
JinnyYi reviewed Oct 21, 2021
View reviewed changes
services/onedrive/utils.go Outdated Show resolved Hide resolved
@JinnyYi JinnyYi merged commit 78fc7b6 into beyondstorage:master Oct 21, 2021
@Joey-1445601153 Joey-1445601153 deleted the onedrive branch October 21, 2021 05:57
@BeyondRobot BeyondRobot mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinnyYi JinnyYi JinnyYi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joey-1445601153 @Xuanwo @JinnyYi @zhangjiayu2132