refactor: use fiber constant for error message (italia#168)

bfabio · Mar 7, 2024 · 758a3ae · 758a3ae
1 parent fbc80f7
commit 758a3ae
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/internal/handlers/logs.go b/internal/handlers/logs.go
@@ -76,7 +76,11 @@ func (p *Log) GetLog(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, "can't get Log", "Log was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't get Log", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't get Log",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	return ctx.JSON(&log)
@@ -118,7 +122,7 @@ func (p *Log) PatchLog(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, errMsg, "Log was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, errMsg, "internal server error")
+		return common.Error(fiber.StatusInternalServerError, errMsg, fiber.ErrInternalServerError.Message)
 	}
 
 	log.Message = logReq.Message

diff --git a/internal/handlers/publishers.go b/internal/handlers/publishers.go
@@ -88,7 +88,11 @@ func (p *Publisher) GetPublisher(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, "can't get Publisher", "Publisher was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't get Publisher", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't get Publisher",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	return ctx.JSON(&publisher)
@@ -155,7 +159,7 @@ func (p *Publisher) PostPublisher(ctx *fiber.Ctx) error {
 		default:
 			return common.Error(fiber.StatusInternalServerError,
 				"can't create Publisher",
-				"internal server error")
+				fiber.ErrInternalServerError.Message)
 		}
 	}
 

diff --git a/internal/handlers/software.go b/internal/handlers/software.go
@@ -182,7 +182,7 @@ func (p *Software) PatchSoftware(ctx *fiber.Ctx) error { //nolint:funlen,cyclop
 			return common.Error(fiber.StatusNotFound, errMsg, "Software was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, errMsg, err.Error())
+		return common.Error(fiber.StatusInternalServerError, errMsg, fiber.ErrInternalServerError.Message)
 	}
 
 	if err := common.ValidateRequestEntity(ctx, &softwareReq, errMsg); err != nil {

diff --git a/internal/handlers/webhooks.go b/internal/handlers/webhooks.go
@@ -28,7 +28,11 @@ func (p *Webhook[T]) GetWebhook(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, "can't get Webhook", "Webhook was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't get Webhook", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't get Webhook",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	return ctx.JSON(&webhook)