Correct comment, delete related code to refine the readability.#230
Closed
kira1928 wants to merge 1 commit intobfirsh:masterfrom
kira1928:correct-comment
Closed
Correct comment, delete related code to refine the readability.#230kira1928 wants to merge 1 commit intobfirsh:masterfrom kira1928:correct-comment
kira1928 wants to merge 1 commit intobfirsh:masterfrom
kira1928:correct-comment
Conversation
Owner
|
Hi @kira1928! Thanks for the contribution. Have you got some more details about what this change is and why it is not needed? A test to demonstrate the behavior would be really helpful. |
Contributor
Author
|
Hi @bfirsh ! |
Owner
|
I'm going to close this until we figure out what this was about. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct comment, delete related code to fit the real logic.
jsnes/src/cpu.js
Lines 321 to 343 in 94f8744