This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Add repo permissions support #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 25, 2015 10:10
|
I copied the other maintainers on #109 to see if we should worry about adding tests before/after this PR so you don't have to wait. Have you been using this in a branch okay? If you have ideas for LWRP testing, please feel free to comment on that other issue. Thank you! |
|
I have been using it at a customers site, although that was before I cleaned up the branch for the PR. Sorry i've not looked at this in the last couple of weeks, I have been busy with another customer. I will have another look at fixing the remaining rubocop errors this week, and will discuss with some colleagues about LWRP testing strategies. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to control the permissions of a repo that is managed with the LWRP.
Adds 6 attributes for admin, write and read permissions for users and groups in stash. It will ensure that the permissions set in the LWRP are applied, both to add and remove users/groups.
In addition this PR slightly alters the behaviour of the chef-stash install, to only override the gem source from the system default if specified in the attributes.